mirror of
https://github.com/git/git.git
synced 2024-05-06 15:46:41 +02:00
12c2ee5fbd
In https://github.com/microsoft/git/issues/623, it was reported that the regularly scheduled maintenance stops if one repo in the middle of the list was found to be missing. This is undesirable, and points out a gap in the design of `git for-each-repo`: We need a mode where that command does not stop on an error, but continues to try running the specified command with the other repositories. Imitating the `--keep-going` option of GNU make, this commit teaches `for-each-repo` the same trick: to continue with the operation on all the remaining repositories in case there was a problem with one repository, still setting the exit code to indicate an error occurred. Helped-by: Eric Sunshine <sunshine@sunshineco.com> Helped-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
72 lines
1.7 KiB
C
72 lines
1.7 KiB
C
#include "builtin.h"
|
|
#include "config.h"
|
|
#include "gettext.h"
|
|
#include "parse-options.h"
|
|
#include "path.h"
|
|
#include "repository.h"
|
|
#include "run-command.h"
|
|
#include "string-list.h"
|
|
|
|
static const char * const for_each_repo_usage[] = {
|
|
N_("git for-each-repo --config=<config> [--] <arguments>"),
|
|
NULL
|
|
};
|
|
|
|
static int run_command_on_repo(const char *path, int argc, const char ** argv)
|
|
{
|
|
int i;
|
|
struct child_process child = CHILD_PROCESS_INIT;
|
|
char *abspath = interpolate_path(path, 0);
|
|
|
|
child.git_cmd = 1;
|
|
strvec_pushl(&child.args, "-C", abspath, NULL);
|
|
|
|
for (i = 0; i < argc; i++)
|
|
strvec_push(&child.args, argv[i]);
|
|
|
|
free(abspath);
|
|
|
|
return run_command(&child);
|
|
}
|
|
|
|
int cmd_for_each_repo(int argc, const char **argv, const char *prefix)
|
|
{
|
|
static const char *config_key = NULL;
|
|
int keep_going = 0;
|
|
int i, result = 0;
|
|
const struct string_list *values;
|
|
int err;
|
|
|
|
const struct option options[] = {
|
|
OPT_STRING(0, "config", &config_key, N_("config"),
|
|
N_("config key storing a list of repository paths")),
|
|
OPT_BOOL(0, "keep-going", &keep_going,
|
|
N_("keep going even if command fails in a repository")),
|
|
OPT_END()
|
|
};
|
|
|
|
argc = parse_options(argc, argv, prefix, options, for_each_repo_usage,
|
|
PARSE_OPT_STOP_AT_NON_OPTION);
|
|
|
|
if (!config_key)
|
|
die(_("missing --config=<config>"));
|
|
|
|
err = repo_config_get_string_multi(the_repository, config_key, &values);
|
|
if (err < 0)
|
|
usage_msg_optf(_("got bad config --config=%s"),
|
|
for_each_repo_usage, options, config_key);
|
|
else if (err)
|
|
return 0;
|
|
|
|
for (i = 0; i < values->nr; i++) {
|
|
int ret = run_command_on_repo(values->items[i].string, argc, argv);
|
|
if (ret) {
|
|
if (!keep_going)
|
|
return ret;
|
|
result = 1;
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|