1
0
mirror of https://github.com/git/git.git synced 2024-09-25 13:21:31 +02:00

git-web--browse: Fix check for /bin/start

The previous check in git-web--browse for /bin/start used test -n
/bin/start, which was always true.  This lead to "start" being tried
first in the browser list.  On systems with upstart installed, "start"
exists and might be in the PATH, but it makes a poor choice for a web
browser.  Instead, test that /bin/start exists and is executable.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Todd Zullinger 2009-02-08 18:12:43 -05:00 committed by Junio C Hamano
parent df487baa30
commit f6b98e46bd

View File

@ -115,7 +115,7 @@ if test -z "$browser" ; then
browser_candidates="open $browser_candidates"
fi
# /bin/start indicates MinGW
if test -n /bin/start; then
if test -x /bin/start; then
browser_candidates="start $browser_candidates"
fi