mirror/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-19 07:32:44 +01:00
Code

fetch/clone: mark messages from remote side stand out.

Browse Source 
When dealing with a corrupt or out of sync remote repository,
the user often gets error messages like this:

	error: refs/heads/devel does not point to a valid commit object!

which leaves the user wondering if the breakage is on the local
end or on the remote end.  This is unnecessarily alarming.

This patch changes the way we display messages received from the
remote side over the git protocol sideband (i.e. stderr stream
of the remote process).  It shows them with blue background with
white letters, but this presentation is subject to proposals of
better ways from the list.

The problem was pointed out by Andrew Morton.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2006-08-01 01:34:53 -07:00
parent bc9e1b8483
commit dfa4647812
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fetch-clone.c
View File

@ -133,7 +133,10 @@ static pid_t setup_sideband(int sideband, const char *me, int fd[2], int xd[2])
fprintf(stderr, "\n");
exit(1);
case 2:
/* color sideband */
safe_write(2, "\033[44;37;1m", 10);
safe_write(2, buf+1, len);
safe_write(2, "\033[m", 3);
continue;
case 1:
safe_write(fd[1], buf+1, len);