mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-05-30 05:36:08 +02:00
Code

t0610: fix non-portable variable assignment 

Older versions of the Dash shell fail to parse `local var=val`
assignments in some cases when `val` is unquoted. Such failures can be
observed e.g. with Ubuntu 20.04 and older, which has a Dash version that
still has this bug.

Such an assignment has been introduced in t0610. The issue wasn't
detected for a while because this test used to only run when the
GIT_TEST_DEFAULT_REF_FORMAT environment variable was set to "reftable".
We have dropped that requirement now though, meaning that it runs
unconditionally, including on jobs which use such older versions of
Ubuntu.

We have worked around such issues in the past, e.g. in ebee5580ca
(parallel-checkout: avoid dash local bug in tests, 2021-06-06), by
quoting the `val` side. Apply the same fix to t0610.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2024-04-12 06:44:53 +02:00 committed by Junio C Hamano
parent ca13c3e94a
commit db1d63bf57
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
t/t0610-reftable-basics.sh
View File

@ -78,9 +78,9 @@ test_expect_success 'init: reinitializing reftable with files backend fails' '
'
test_expect_perms () {
local perms="$1"
local file="$2"
local actual=$(ls -l "$file") &&
local perms="$1" &&
local file="$2" &&
local actual="$(ls -l "$file")" &&
case "$actual" in
$perms*)