mirror of
https://github.com/git/git.git
synced 2024-05-06 04:06:14 +02:00
imap-send: drop unused fields from imap_cmd_cb
The imap_cmd_cb struct has several fields which are totally unused. Presumably they did useful things in the upstream isync code from which this is derived, but they don't in our more limited program. This is particularly confusing for the "done" callback, which (as of the previous patch) no longer matches the signature of the adjacent "cont" callback. Since we're unlikely to share code with isync going forward, we should feel free to simplify the code here. Note that "done" is examined but never set, so we can also drop a little bit of code outside of the struct definition. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
ec9e358a4a
commit
d378637d2f
|
@ -138,11 +138,9 @@ struct imap_store {
|
|||
|
||||
struct imap_cmd_cb {
|
||||
int (*cont)(struct imap_store *ctx, const char *prompt);
|
||||
void (*done)(struct imap_store *ctx, struct imap_cmd *cmd, int response);
|
||||
void *ctx;
|
||||
char *data;
|
||||
int dlen;
|
||||
int uid;
|
||||
};
|
||||
|
||||
struct imap_cmd {
|
||||
|
@ -828,8 +826,6 @@ static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
|
|||
}
|
||||
if ((resp2 = parse_response_code(ctx, &cmdp->cb, cmd)) > resp)
|
||||
resp = resp2;
|
||||
if (cmdp->cb.done)
|
||||
cmdp->cb.done(ctx, cmdp, resp);
|
||||
free(cmdp->cb.data);
|
||||
free(cmdp->cmd);
|
||||
free(cmdp);
|
||||
|
|
Loading…
Reference in New Issue