mirror/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-10-18 12:18:44 +02:00
Code

transport-helper: use write helpers more consistently

Browse Source 
The transport-helper code provides some functions for writing to the
helper process, but there are a few spots that don't use them. We should
do so consistently because:

  1. They detect errors on write (though in practice this means the
     helper process went away, and we'd see the problem as soon as we
     try to read the response).

  2. They dump the written bytes to the GIT_TRANSPORT_HELPER_DEBUG
     stream. It's doubly confusing to miss some writes but not others,
     as you see a partial conversation.

The "list" ones go all the way back to the beginning of the transport
helper code; they were just missed when most writes were converted in
bf3c523c3f (Add remote helper debug mode, 2009-12-09). The nearby
"object-format" write presumably just cargo-culted them, as it's only a
few lines away.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2024-03-20 05:34:17 -04:00 committed by Junio C Hamano
parent e09f1254c5
commit cf7335f5b6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
transport-helper.c
View File

@ -1211,15 +1211,15 @@ static struct ref *get_refs_list_using_list(struct transport *transport,
helper = get_helper(transport);
if (data->object_format) {
write_str_in_full(helper->in, "option object-format\n");
write_constant(helper->in, "option object-format\n");
if (recvline(data, &buf) || strcmp(buf.buf, "ok"))
exit(128);
}
if (data->push && for_push)
write_str_in_full(helper->in, "list for-push\n");
write_constant(helper->in, "list for-push\n");
else
write_str_in_full(helper->in, "list\n");
write_constant(helper->in, "list\n");
while (1) {
char *eov, *eon;