From f45982337aab3b3d289692027ce00b130b967ffa Mon Sep 17 00:00:00 2001 From: Alexander Kuleshov Date: Fri, 19 Feb 2016 14:44:48 +0600 Subject: [PATCH] exec_cmd.c: use find_last_dir_sep() for code simplification We are trying to extract dirname from argv0 in the git_extract_argv0_path(). But in the same time, the provides find_last_dir_sep() to get dirname from a given path. Let's use it instead of loop for the code simplification. Signed-off-by: Alexander Kuleshov Signed-off-by: Junio C Hamano --- exec_cmd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/exec_cmd.c b/exec_cmd.c index e85f0fd8d8..680b257cd5 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -43,12 +43,10 @@ const char *git_extract_argv0_path(const char *argv0) if (!argv0 || !*argv0) return NULL; - slash = argv0 + strlen(argv0); - while (argv0 <= slash && !is_dir_sep(*slash)) - slash--; + slash = find_last_dir_sep(argv0); - if (slash >= argv0) { + if (slash) { argv0_path = xstrndup(argv0, slash - argv0); return slash + 1; }