mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-06-05 00:26:25 +02:00
Code

fsck: fix leak when traversing trees 

While fsck_walk/fsck_walk_tree/parse_tree populates "struct tree"
idempotently, it is still up to the fsck_walk caller to call
free_tree_buffer.

Fixes: ad2db4030e ("fsck: remove redundant parse_tree() invocation")

Signed-off-by: Eric Wong <e@80x24.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Eric Wong 2018-01-20 07:43:51 +00:00 committed by Junio C Hamano
parent 78e7b98f45
commit ba3a08ca0e
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
builtin/fsck.c
View File

@ -170,7 +170,13 @@ static void mark_object_reachable(struct object *obj)
static int traverse_one_object(struct object *obj)
{
return fsck_walk(obj, obj, &fsck_walk_options);
int result = fsck_walk(obj, obj, &fsck_walk_options);
if (obj->type == OBJ_TREE) {
struct tree *tree = (struct tree *)obj;
free_tree_buffer(tree);
}
return result;
}
static int traverse_reachable(void)