1
0
mirror of https://github.com/git/git.git synced 2024-11-18 04:53:58 +01:00

git-rev-list: remove the DUPCHECK logic, use SEEN instead

That's what we should have done in the first place, since it not only
avoids another unnecessary flag, it also protects the commits from
showing up as duplicates later when they show up as parents of another
commit (in the pop_most_recent_commit() path).

This will hopefully also fix --topo-sort.
This commit is contained in:
Linus Torvalds 2005-07-06 16:52:49 -07:00
parent e6c3505b44
commit 960cea2dd1

@ -9,7 +9,6 @@
#define INTERESTING (1u << 1)
#define COUNTED (1u << 2)
#define SHOWN (1u << 3)
#define DUPCHECK (1u << 4)
static const char rev_list_usage[] =
"usage: git-rev-list [OPTION] commit-id <commit-id>\n"
@ -488,9 +487,9 @@ int main(int argc, char **argv)
commit = get_commit_reference(arg, flags);
if (!commit)
continue;
if (commit->object.flags & DUPCHECK)
if (commit->object.flags & SEEN)
continue;
commit->object.flags |= DUPCHECK;
commit->object.flags |= SEEN;
insert(commit, &list);
}