From 8d5cf957352badca4575cc85c020d6cf73db86f7 Mon Sep 17 00:00:00 2001 From: Jonathan Tan Date: Mon, 20 Jul 2020 17:21:43 -0700 Subject: [PATCH] pack-objects: refactor to oid_object_info_extended Use oid_object_info_extended() instead of oid_object_info() because a subsequent commit needs to specify an additional flag here. Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano --- builtin/pack-objects.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 7016b28485..e09d140eed 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -1707,6 +1707,8 @@ static int can_reuse_delta(const struct object_id *base_oid, static void check_object(struct object_entry *entry) { unsigned long canonical_size; + enum object_type type; + struct object_info oi = {.typep = &type, .sizep = &canonical_size}; if (IN_PACK(entry)) { struct packed_git *p = IN_PACK(entry); @@ -1840,8 +1842,10 @@ static void check_object(struct object_entry *entry) unuse_pack(&w_curs); } - oe_set_type(entry, - oid_object_info(the_repository, &entry->idx.oid, &canonical_size)); + if (oid_object_info_extended(the_repository, &entry->idx.oid, &oi, + OBJECT_INFO_LOOKUP_REPLACE) < 0) + type = -1; + oe_set_type(entry, type); if (entry->type_valid) { SET_SIZE(entry, canonical_size); } else {