mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-06-02 07:06:10 +02:00
Code

[PATCH] git-send-email-script: Reformat readline interface and generate a better message-id. 

Signed-off-by: Ryan Anderson <ryan@michonline.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Ryan Anderson 2005-07-31 20:04:24 -04:00 committed by Junio C Hamano
parent 78488b2c4d
commit 8037d1a31a
1 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
git-send-email-script
View File

@ -69,30 +69,38 @@ close(GITVAR);
if (!defined $from) { if (!defined $from) {
$from = $author || $committer; $from = $author || $committer;
1 while (!defined ($_ = $term->readline("Who should the emails appear to be from? ", do {
$from))); $_ = $term->readline("Who should the emails appear to be from? ",
$from);
while (!defined $_);
$from = $_; $from = $_;
print "Emails will be sent from: ", $from, "\n"; print "Emails will be sent from: ", $from, "\n";
} }
if (!@to) { if (!@to) {
1 while (!defined ($_ = $term->readline("Who should the emails be sent to? ", do {
""))); $_ = $term->readline("Who should the emails be sent to? ",
"");
} while (!defined $_);
my $to = $_; my $to = $_;
push @to, split /,/, $to; push @to, split /,/, $to;
} }
if (!defined $initial_subject) { if (!defined $initial_subject) {
1 while (!defined ($_ = do {
$term->readline("What subject should the emails start with? ", $_ = $term->readline("What subject should the emails start with? ",
$initial_subject))); $initial_subject);
} while (!defined $_);
$initial_subject = $_; $initial_subject = $_;
} }
if (!defined $initial_reply_to) { if (!defined $initial_reply_to) {
1 while (!defined ($_ = do {
$term->readline("Message-ID to be used as In-Reply-To? ", $_= $term->readline("Message-ID to be used as In-Reply-To? ",
$initial_reply_to))); $initial_reply_to);
} while (!defined $_);
$initial_reply_to = $_; $initial_reply_to = $_;
$initial_reply_to =~ s/(^\s+|\s+$)//g; $initial_reply_to =~ s/(^\s+|\s+$)//g;
} }
@ -104,8 +112,9 @@ for my $f (@ARGV) {
opendir(DH,$f) opendir(DH,$f)
or die "Failed to opendir $f: $!"; or die "Failed to opendir $f: $!";
push @files, map { +$f . "/" . $_ } grep !/^\.{1,2}$/, push @files, map { +$f . "/" . $_ } grep { -f $_ }
sort readdir(DH); sort readdir(DH);
} elsif (-f $f) { } elsif (-f $f) {
push @files, $f; push @files, $f;
@ -142,13 +151,18 @@ our ($message_id, $cc, %mail, $subject, $reply_to, $message);
# of seconds since the beginning of Unix time and tacking on # of seconds since the beginning of Unix time and tacking on
# a random number to the end, in case we are called quicker than # a random number to the end, in case we are called quicker than
# 1 second since the last time we were called. # 1 second since the last time we were called.
# We'll setup a template for the message id, using the "from" address:
my $message_id_from = Email::Valid->address($from);
my $message_id_template = "<%s-git-send-email-$from>";
sub make_message_id sub make_message_id
{ {
my $date = `date "+\%s"`; my $date = `date "+\%s"`;
chomp($date); chomp($date);
my $pseudo_rand = int (rand(4200)); my $pseudo_rand = int (rand(4200));
$message_id = "<$date$pseudo_rand\@foobar.com>"; $message_id = sprintf $message_id_template, "$date$pseudo_rand";
print "new message id = $message_id\n"; #print "new message id = $message_id\n"; # Was useful for debugging
} }