mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-05-26 19:56:11 +02:00
Code

t: local VAR="VAL" (quote command substitution) 

Future-proof test scripts that do

	local VAR=VAL

without quoting VAL (which is OK in POSIX but broken in some shells)
that is a $(command substitution).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2024-04-05 17:09:00 -07:00
parent 341aad8d41
commit 7f9f230b7f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/t4011-diff-symlink.sh
View File

@ -13,13 +13,13 @@ TEST_PASSES_SANITIZE_LEAK=true
# Print the short OID of a symlink with the given name. # Print the short OID of a symlink with the given name.
symlink_oid () { symlink_oid () {
local oid=$(printf "%s" "$1" | git hash-object --stdin) && local oid="$(printf "%s" "$1" | git hash-object --stdin)" &&
git rev-parse --short "$oid" git rev-parse --short "$oid"
} }
# Print the short OID of the given file. # Print the short OID of the given file.
short_oid () { short_oid () {
local oid=$(git hash-object "$1") && local oid="$(git hash-object "$1")" &&
git rev-parse --short "$oid" git rev-parse --short "$oid"
} }

2
t/test-lib-functions.sh
View File

@ -1840,7 +1840,7 @@ test_subcommand () {
shift shift
fi fi
local expr=$(printf '"%s",' "$@") local expr="$(printf '"%s",' "$@")"
expr="${expr%,}" expr="${expr%,}"
if test -n "$negate" if test -n "$negate"