mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-06-04 08:06:14 +02:00
Code

sha1-file: close fd of empty file in map_sha1_file_1() 

map_sha1_file_1() checks if the file it is about to mmap() is empty and
errors out in that case and explains the situation in an error message.
It leaks the private handle to that empty file, though.

Have the function clean up after itself and close the file descriptor
before exiting early.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2019-01-07 17:48:02 +01:00 committed by Junio C Hamano
parent 0d0ac3826a
commit 6881925ef5
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sha1-file.c
View File

@ -971,6 +971,7 @@ static void *map_sha1_file_1(struct repository *r, const char *path,
if (!*size) {
/* mmap() is forbidden on empty files */
error(_("object file %s is empty"), path);
close(fd);
return NULL;
}
map = xmmap(NULL, *size, PROT_READ, MAP_PRIVATE, fd, 0);