mirror/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-10-18 16:58:12 +02:00
Code

refs/files: refactor add_pseudoref_and_head_entries()

Browse Source 
The `add_pseudoref_and_head_entries()` function accepts both the ref
store as well as a directory name as input. This is unnecessary though
as the ref store already uniquely identifies the root directory of the
ref store anyway.

Furthermore, the function is misnamed now that we have clarified the
meaning of pseudorefs as it doesn't add pseudorefs, but root refs.
Rename it accordingly.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2024-06-06 07:29:16 +02:00 committed by Junio C Hamano
parent fbd1a693c7
commit 66275a6311
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
refs/files-backend.c
View File

@ -324,16 +324,14 @@ static void loose_fill_ref_dir(struct ref_store *ref_store,
}
/*
* Add pseudorefs to the ref dir by parsing the directory for any files
* which follow the pseudoref syntax.
* Add root refs to the ref dir by parsing the directory for any files which
* follow the root ref syntax.
*/
static void add_pseudoref_and_head_entries(struct ref_store *ref_store,
struct ref_dir *dir,
const char *dirname)
static void add_root_refs(struct files_ref_store *refs,
struct ref_dir *dir)
{
struct files_ref_store *refs =
files_downcast(ref_store, REF_STORE_READ, "fill_ref_dir");
struct strbuf path = STRBUF_INIT, refname = STRBUF_INIT;
const char *dirname = refs->loose->root->name;
struct dirent *de;
size_t dirnamelen;
DIR *d;
@ -388,8 +386,7 @@ static struct ref_cache *get_loose_ref_cache(struct files_ref_store *refs,
dir = get_ref_dir(refs->loose->root);
if (flags & DO_FOR_EACH_INCLUDE_ROOT_REFS)
add_pseudoref_and_head_entries(dir->cache->ref_store, dir,
refs->loose->root->name);
add_root_refs(refs, dir);
/*
* Add an incomplete entry for "refs/" (to be filled