From 5205749d2ca81ea1d124ba7d799f4b319084ca68 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 20 Mar 2019 04:16:27 -0400 Subject: [PATCH] parse-options: drop unused ctx parameter from show_gitcomp() The completion display doesn't actually care about where we are in the parsing. It's generated completely from the set of available options. So we don't need to see the parse-options context struct at all. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- parse-options.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/parse-options.c b/parse-options.c index cec74522e5..ade83a7b20 100644 --- a/parse-options.c +++ b/parse-options.c @@ -523,8 +523,7 @@ static void show_negated_gitcomp(const struct option *opts, int nr_noopts) } } -static int show_gitcomp(struct parse_opt_ctx_t *ctx, - const struct option *opts) +static int show_gitcomp(const struct option *opts) { const struct option *original_opts = opts; int nr_noopts = 0; @@ -603,7 +602,7 @@ int parse_options_step(struct parse_opt_ctx_t *ctx, /* lone --git-completion-helper is asked by git-completion.bash */ if (ctx->total == 1 && !strcmp(arg + 1, "-git-completion-helper")) - return show_gitcomp(ctx, options); + return show_gitcomp(options); if (arg[1] != '-') { ctx->opt = arg + 1;