mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-05-24 03:46:12 +02:00
Code

cmd_fetch_pack(): handle non-option arguments outside of the loop 

This makes it more obvious that the code is always executed unless
there is an error, and that the first initialization of nr_heads is
unnecessary.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2012-05-21 09:59:57 +02:00 committed by Junio C Hamano
parent 9d19c6ea52
commit 4cc00fcf5d
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
builtin/fetch-pack.c
View File

@ -909,7 +909,6 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
packet_trace_identity("fetch-pack");
nr_heads = 0;
heads = NULL;
for (i = 1; i < argc; i++) {
const char *arg = argv[i];
@ -971,14 +970,17 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
}
usage(fetch_pack_usage);
}
dest = arg;
heads = (char **)(argv + i + 1);
nr_heads = argc - i - 1;
break;
}
if (!dest)
if (i < argc)
dest = argv[i++];
else
usage(fetch_pack_usage);
heads = (char **)(argv + i);
nr_heads = argc - i;
if (args.stdin_refs) {
/*
* Copy refs from cmdline to new growable list, then