mirror/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-11-20 08:33:56 +01:00
Code

pager: do not fork a pager if PAGER is set to empty.

Browse Source 
This skips an extra pipe, and helps debugging tremendously.

[jc: PAGER=cat is a questionable hack and should be done as a separate
patch. ]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Johannes Schindelin 2006-04-16 04:44:25 +02:00 committed by Junio C Hamano
parent 2935327394
commit 402461aab1
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pager.c
View File

@ -5,22 +5,24 @@
* something different on Windows, for example. * something different on Windows, for example.
*/ */
static void run_pager(void) static void run_pager(const char *pager)
{ {
const char *prog = getenv("PAGER"); execlp(pager, pager, NULL);
if (!prog)
prog = "less";
setenv("LESS", "-S", 0);
execlp(prog, prog, NULL);
} }
void setup_pager(void) void setup_pager(void)
{ {
pid_t pid; pid_t pid;
int fd[2]; int fd[2];
const char *pager = getenv("PAGER");
if (!isatty(1)) if (!isatty(1))
return; return;
if (!pager)
pager = "less";
else if (!*pager)
return;
if (pipe(fd) < 0) if (pipe(fd) < 0)
return; return;
pid = fork(); pid = fork();
@ -43,6 +45,7 @@ void setup_pager(void)
close(fd[0]); close(fd[0]);
close(fd[1]); close(fd[1]);
run_pager(); setenv("LESS", "-S", 0);
run_pager(pager);
exit(255); exit(255);
} }