mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-05-17 20:06:15 +02:00
Code

remove unnecessary NULL check before free(3) 

free(3) handles NULL pointers just fine.  Add a semantic patch for
removing unnecessary NULL checks before calling this function, and
apply it on the code base.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2016-10-08 16:14:57 +02:00 committed by Junio C Hamano
parent 353d84c537
commit 39ea59a257
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/coccinelle/free.cocci Normal file
View File

@ -0,0 +1,5 @@
@@
expression E;
@@
- if (E)
free(E);

3
parse-options-cb.c
View File

@ -199,8 +199,7 @@ int parse_opt_passthru(const struct option *opt, const char *arg, int unset)
if (recreate_opt(&sb, opt, arg, unset) < 0)
return -1;
if (*opt_value)
free(*opt_value);
free(*opt_value);
*opt_value = strbuf_detach(&sb, NULL);