mirror/git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-09-28 15:01:31 +02:00
Code

name-rev: don't leak path copy in name_ref()

Browse Source 
name_ref() duplicates the path string and passes it to name_rev(), which
either puts it into a commit slab or ignores it if there is already a
better name, leaking it.  Move the duplication to name_rev() and release
the copy in the latter case.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2020-02-04 22:17:02 +01:00 committed by Junio C Hamano
parent 36d2419c9a
commit 15a4205d96
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/name-rev.c
View File

@ -121,6 +121,8 @@ static void name_rev(struct commit *start_commit,
if (deref)
tip_name = to_free = xstrfmt("%s^0", tip_name);
else
tip_name = to_free = xstrdup(tip_name);
if (!create_or_update_name(start_commit, tip_name, taggerdate, 0, 0,
from_tag)) {
@ -323,7 +325,7 @@ static int name_ref(const char *path, const struct object_id *oid, int flags, vo
if (taggerdate == TIME_MAX)
taggerdate = commit->date;
path = name_ref_abbrev(path, can_abbreviate_output);
name_rev(commit, xstrdup(path), taggerdate, from_tag, deref);
name_rev(commit, path, taggerdate, from_tag, deref);
}
return 0;
}