mirror/ git
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2024-06-10 09:56:10 +02:00
Code

t5150: skip request-pull test if Perl is disabled 

The git-request-pull.sh script invokes Perl, so it requires Perl to be
available, but the associated test t5150 does not skip itself when Perl
has been disabled, which then makes subtest 4 through 10 fail. Subtest 3
still passes, but for the wrong reasons (it expects git-request-pull to
fail, and it does fail when Perl is not available). The initial two
subtests that do pass are only doing setup.

To prevent t5150 from failing the build when NO_PERL=1, add a check that
sets skip_all when "! test_have_prereq PERL", just like how for example
t3701-add-interactive skips itself when Perl has been disabled.

Signed-off-by: Ruud van Asseldonk <dev@veniogames.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ruud van Asseldonk 2019-11-26 01:02:46 +01:00 committed by Junio C Hamano
parent d9f6f3b619
commit 13ca8fb79e
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
t/t5150-request-pull.sh
View File

@ -4,6 +4,12 @@ test_description='Test workflows involving pull request.'
. ./test-lib.sh
if ! test_have_prereq PERL
then
skip_all='skipping request-pull tests, perl not available'
test_done
fi
test_expect_success 'setup' '
git init --bare upstream.git &&