1
1
Fork 0
mirror of https://github.com/docker-mailserver/docker-mailserver synced 2024-05-30 06:56:06 +02:00
docker-mailserver/test/test_helper
Brennan Kinney f4f0e4ef61
tests: Refactored bounced spam test + Introduce common container setup template (#2198)
* fix: Spam bounced test copy/paste typo
* tests(docs): Expand inline documentation

Should assist maintainers like myself that are not yet familiar with this functionality, saving some time :)

* Refactor bounced test + Introduce initial container template

DRY'd up the test and extracted a common init pattern for other tests to adopt in future.

The test does not need to run distinct containers at once, so a common name is fine, although the `init_with_defaults()` method could be given an arg to add a suffix: `init_with_defaults "_${BATS_TEST_NUMBER}"` which could be called in `setup()` for tests that can benefit from being run in parallel.

Often it seems the containers only need the bare minimum config such as accounts provided to actually make the container happy to perform a test, so sharing a `:ro` config mount is fine, or in future this could be better addressed.

---

The test would fail if the test cases requiring smtp access ran before postfix was ready (_only a few seconds after setup scripts announce being done_). Added the wait condition for smtp, took a while to track that failure down.
2021-09-20 19:35:03 +12:00
..
bats-assert@9f88b4207d Add bats asserts (#463) 2017-01-10 14:15:41 +01:00
bats-support@004e707638 Add bats asserts (#463) 2017-01-10 14:15:41 +01:00
common.bash tests: Refactored bounced spam test + Introduce common container setup template (#2198) 2021-09-20 19:35:03 +12:00