From 5071cb555eefa5d553dafb352a7d9efb50a3377a Mon Sep 17 00:00:00 2001 From: Andrea Cardaci Date: Thu, 8 Sep 2022 21:11:17 +0200 Subject: [PATCH] Fix suid and sudo function names --- _gtfobins/tmate.md | 2 +- contribute.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_gtfobins/tmate.md b/_gtfobins/tmate.md index 78a793c..fc2ffe0 100644 --- a/_gtfobins/tmate.md +++ b/_gtfobins/tmate.md @@ -4,6 +4,6 @@ functions: - code: tmate -c /bin/sh sudo: - code: sudo tmate -c /bin/sh - suid-limited: + limited-suid: - code: ./tmate -c /bin/sh --- diff --git a/contribute.md b/contribute.md index 928a983..87ac86e 100644 --- a/contribute.md +++ b/contribute.md @@ -37,10 +37,10 @@ Before sending a pull request of a new binary or function, ensure the following: 1. Verify the function works on at least one type of modern Unix system. 2. Classifying SUID-related functions is tricky because they depend on the default shell (i.e. Debian `/bin/sh` doesn't drop the privileges, other Linux default shells do it) and on how the external command is called (i.e. `exec()` family vs. `system()` calls). Here an helpful check: - - The function is `suid-enabled` if runs external commands on Ubuntu Linux maintaining the SUID privileges. - - The function is `suid-limited` if runs external commands on Debian maintaining the SUID privileges, but it drops them on Ubuntu Linux. + - The function is `suid` if runs external commands on Ubuntu Linux maintaining the SUID privileges. + - The function is `limited-suid` if runs external commands on Debian maintaining the SUID privileges, but it drops them on Ubuntu Linux. - The function is not `suid-*` flagged if drops the privileges in Debian Linux. -3. Verify `sudo-enabled` function runs external commands under the `sudo` privileged context. +3. Verify `sudo` function runs external commands under the `sudo` privileged context. Pull requests adding new functions in [`_data/functions.yml`] are allowed and subjected to project maintainers vetting.