mirror/GTFOBins.github.io
1
0
Fork 0
mirror of https://github.com/GTFOBins/GTFOBins.github.io.git synced 2024-11-08 07:49:17 +01:00
Code Issues

Rephrase SUID validation in contribute.md

Browse Source
This commit is contained in:
Emilio Pinna 2018-05-24 08:04:03 +01:00
parent 414ee88fd8
commit 2d1c051d1c
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
contribute.md
View File

@ -37,9 +37,10 @@ Vendor software is accepted as well as standard Unix binaries. Binaries and tech
Before sending a pull request of a new binary or function, ensure the following:
1. Verify the function works on at least one type of modern Unix system.
2. Classifying SUID-related functions may be tricky because they depend on how the default shell behaves on different systems (i.e. Ubuntu vs. Debian) and how the external command is called (i.e. `exec()` family vs. `system()`). Check how the binary behaves:
- The function is considered `suid-enabled` if runs external commands with SUID privileges on Ubuntu Linux.
- The function is considered `suid-limited` if runs external commands with SUID privileges on Debian but it drops the privileges on Ubuntu Linux.
2. Classifying SUID-related functions is tricky because they depend on the default shell (i.e. Debian `/bin/sh` doesn't drop the privileges, other Linux default shells do it) and on how the external command is called (i.e. `exec()` family vs. `system()` calls). Here an helpful check:
- The function is `suid-enabled` if runs external commands on Ubuntu Linux maintaining the SUID privileges.
- The function is `suid-limited` if runs external commands on Debian maintaining the SUID privileges, but it drops them on Ubuntu Linux.
- The function is not `suid-*` flagged if drops the privileges in Debian Linux.
3. Verify `sudo-enabled` function runs external commands under the `sudo` privileged context.
Pull requests adding new functions in `_data/functions.yml` are allowed and subjected to project maintainers vetting.