ak-fortuna/ fortuna
Archived
1
1
Fork 1
Code Issues 2 Pull Requests Projects Releases 1 Activity

std::string --> char array where meaningful #8

New Issue
Open
opened 2022-01-07 05:44:48 +01:00 by wanderer · 0 comments
wanderer commented 2022-01-07 05:44:48 +01:00
Owner
Copy Link

since strings are \0-terminated, this makes for an ugly issue down the road unless it's fixed very soon (std::string has been overused).

examples/candidates:
d4c7c61ac4/generator.cpp (L49-L50)
d4c7c61ac4/generator.cpp (L57-L58)
d4c7c61ac4/generator.cpp (L135)
d4c7c61ac4/util.h (L16-L30)
d4c7c61ac4/generator.cpp (L127)

since strings are `\0`-terminated, this makes for an ugly issue down the road unless it's fixed very soon (`std::string` has been overused). examples/candidates: https://git.dotya.ml/ak-fortuna/fortuna/src/commit/d4c7c61ac47baa7c5dd73029f4692c5c4e7afc50/generator.cpp#L49-L50 https://git.dotya.ml/ak-fortuna/fortuna/src/commit/d4c7c61ac47baa7c5dd73029f4692c5c4e7afc50/generator.cpp#L57-L58 https://git.dotya.ml/ak-fortuna/fortuna/src/commit/d4c7c61ac47baa7c5dd73029f4692c5c4e7afc50/generator.cpp#L135 https://git.dotya.ml/ak-fortuna/fortuna/src/commit/d4c7c61ac47baa7c5dd73029f4692c5c4e7afc50/util.h#L16-L30 https://git.dotya.ml/ak-fortuna/fortuna/src/commit/d4c7c61ac47baa7c5dd73029f4692c5c4e7afc50/generator.cpp#L127
wanderer added the
bug
 label 2022-01-07 05:44:48 +01:00
wanderer self-assigned this 2022-01-07 05:44:48 +01:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
development
add-random-sources
fixing-generator
finalise-generator
move-to-oop-paradigm
v0.1.0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

Something's improving

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
wanderer
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ak-fortuna/fortuna#8
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?