also currently, we're not planning to be all that portable (ikr..) and we also cannot get rid the 128bit integer (at least at the moment I don't see a way that wouldn't require some kind of array implementation tomfoolery).
perhaps have a separate ci step called "portability" and turn this warning on there but remove it from CMakeLists.txt, i.e. don't use it for standard builds.
rm "-Wpedantic" from CMakeLists.txt
add "portability" step to ci with the subject warning flag enabled
currently, `-Wpedantic` is a part of `CMAKE_CXX_FLAGS` for debug builds`[ref1]` and produces warnings like this`[ref2]`:
```
generator.h:25:44: warning: ISO C++ does not support ‘__int128’ for ‘ctr’ [-Wpedantic]
```
ref1: https://git.dotya.ml/ak-fortuna/fortuna/src/commit/bad86c31df32e7f72371140a738a25108bfc872d/CMakeLists.txt#L35-L37
ref2: https://git.dotya.ml/ak-fortuna/fortuna/src/commit/bad86c31df32e7f72371140a738a25108bfc872d/generator.h#L23
also currently, we're not planning to be all that portable (ikr..) and we also cannot get rid the 128bit integer (at least at the moment I don't see a way that wouldn't require some kind of array implementation tomfoolery).
perhaps have a separate ci step called "portability" and turn this warning on there but remove it from CMakeLists.txt, i.e. don't use it for standard builds.
- [ ] rm "-Wpedantic" from CMakeLists.txt
- [ ] add "portability" step to ci with the subject warning flag enabled
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
currently,
-Wpedanticis a part ofCMAKE_CXX_FLAGSfor debug builds[ref1]and produces warnings like this[ref2]:ref1:
ref2:
also currently, we're not planning to be all that portable (ikr..) and we also cannot get rid the 128bit integer (at least at the moment I don't see a way that wouldn't require some kind of array implementation tomfoolery).
perhaps have a separate ci step called "portability" and turn this warning on there but remove it from CMakeLists.txt, i.e. don't use it for standard builds.