rm -Wpedantic from general purpose builds #2

New Issue

wanderer · 2021-11-13T00:38:42+01:00

wanderer commented

2021-11-13 00:38:42 +01:00

currently, -Wpedantic is a part of CMAKE_CXX_FLAGS for debug builds[ref1] and produces warnings like this[ref2]:

generator.h:25:44: warning: ISO C++ does not support ‘__int128’ for ‘ctr’ [-Wpedantic]

ref1:

		CMakeLists.txt
		Lines 35 to 37 in bad86c31df
	
				    if(NOT CMAKE_CXX_FLAGS MATCHES "-Wpedantic")

				      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wpedantic")

				    endif(NOT CMAKE_CXX_FLAGS MATCHES "-Wpedantic")

ref2:

		generator.h
		Line 23 in bad86c31df
	
					auto do_crypto(int64_t k, unsigned __int128 ctr) -> string;

also currently, we're not planning to be all that portable (ikr..) and we also cannot get rid the 128bit integer (at least at the moment I don't see a way that wouldn't require some kind of array implementation tomfoolery).

perhaps have a separate ci step called "portability" and turn this warning on there but remove it from CMakeLists.txt, i.e. don't use it for standard builds.

rm "-Wpedantic" from CMakeLists.txt
add "portability" step to ci with the subject warning flag enabled

currently, `-Wpedantic` is a part of `CMAKE_CXX_FLAGS` for debug builds`[ref1]` and produces warnings like this`[ref2]`: ``` generator.h:25:44: warning: ISO C++ does not support ‘__int128’ for ‘ctr’ [-Wpedantic] ``` ref1: https://git.dotya.ml/ak-fortuna/fortuna/src/commit/bad86c31df32e7f72371140a738a25108bfc872d/CMakeLists.txt#L35-L37 ref2: https://git.dotya.ml/ak-fortuna/fortuna/src/commit/bad86c31df32e7f72371140a738a25108bfc872d/generator.h#L23 also currently, we're not planning to be all that portable (ikr..) and we also cannot get rid the 128bit integer (at least at the moment I don't see a way that wouldn't require some kind of array implementation tomfoolery). perhaps have a separate ci step called "portability" and turn this warning on there but remove it from CMakeLists.txt, i.e. don't use it for standard builds. - [ ] rm "-Wpedantic" from CMakeLists.txt - [ ] add "portability" step to ci with the subject warning flag enabled

wanderer added the

enhancement

label 2021-11-13 00:38:42 +01:00

wanderer self-assigned this 2021-11-13 00:38:42 +01:00

wanderer referenced this issue from a commit

2021-11-15 22:57:00 +01:00

generator: silence pedantic warnings for __int128

wanderer closed this issue

2021-11-15 22:57:00 +01:00

This repo is archived. You cannot comment on issues.